Disable pre-commit.ci's PR autofixes#1506
Merged
jakirkham merged 1 commit intozarr-developers:mainfrom Aug 23, 2023
Merged
Conversation
Member
Author
|
cc @d-v-b (for awareness) |
github-actions
bot
added
the
needs release notes
Member
Author
|
pre-commit.ci autofix |
Member
Author
|
Adding a release note for this seems silly. This is not a user facing change (just a maintainer one). So going to go ahead and merge (since it seems like we are happy with this change). Thanks all! 🙏 |
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As observed in the past, pre-commit.ci automatically pushes changes to PRs (even when not requested). This has caused issues in some cases ( #1459 ). This disables automatic pushes by pre-commit in PRs (based on the
autofix_prsconfig parameter). It is still possible to ask pre-commit to push a changed, but at least in that case it is an option (and not done without a user request)TODO: